-
Notifications
You must be signed in to change notification settings - Fork 13.8k
Rollup of 6 pull requests #147475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 6 pull requests #147475
Conversation
…Nadrieril clarify wording of match ergonomics diagnostics (`rust_2024_incompatible_pat` lint and error) Partially addresses rust-lang#143557: - Uses different wording than the Edition Guide chapter, to hopefully stand alone a bit better. Instead of referring to the "default binding mode", it now talks about what can't be written "within elided reference patterns". I ended up going with "elided" instead of "implicit" in hope that it reads bit less like it should behave the same as an explicit reference pattern, but I'm not totally happy with that wording. - The explanatory note still points to where the default binding mode was introduced, but only refers to its effect, not what we call it. How that relates to the rest of the diagnostic may still be a bit of a puzzle, but hopefully it isn't too much of one? It also doesn't make sense anymore for the case of `&` written under a by-ref binding mode, so I've left the note out in that case (but kept the label). It's more cramped, but talking about binding modes would feel like a non-sequitur for the error about `&` patterns without further explanation. - Links to the stable version of the Edition Guide instead of the nightly version. It looks like almost every link to the Edition Guide in diagnostics is to the nightly version, presumably for the same reason as here: the diagnostics were added before the new Edition was stabilized, then never updated. I'll make a separate PR to clean up the others. This only changes the diagnostic messages, not the code suggestion or the Edition Guide. r? `@Nadrieril` or reassign
…trochenkov some more `proc_macro` cleanups Several smaller cleanups to `proc_macro`. Commits 1 and 3 seem pretty trivial to me, commit 2 might be worth it or not. Followup to rust-lang#147166.
…ochenkov Convert impossible cases in macro resolution into assertions associated discussion with `@petrochenkov:` [#t-compiler/help > understanding early name resolution of imports @ 💬](https://rust-lang.zulipchat.com/#narrow/channel/182449-t-compiler.2Fhelp/topic/understanding.20early.20name.20resolution.20of.20imports/near/542936677)
prefer repeat_n() over repeat().take()
…ge, r=GuillaumeGomez Add rustdoc crate name in error Fixes rust-lang#147458 I'm not entirely sure if what I am doing with the span is correct
…nikic refactor: replace `LLVMRustAtomicLoad/Store` with LLVM built-in functions This simplifies the code and reduces the burden of maintaining our own wrappers. Work towards rust-lang#46437
@bors r+ rollup=never p=5 |
☀️ Test successful - checks-actions |
📌 Perf builds for each rolled up PR:
previous master: 910617d84d In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing 910617d (parent) -> 7a52736 (this PR) Test differencesNo test diffs found Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 7a52736039856a3626eefec32d80c9df900b7afd --output-dir test-dashboard And then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
Finished benchmarking commit (7a52736): comparison URL. Overall result: ❌ regressions - no action needed@rustbot label: -perf-regression Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (primary -0.0%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (secondary -1.8%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 473.206s -> 472.232s (-0.21%) |
Successful merges:
rust_2024_incompatible_pat
lint and error) #144006 (clarify wording of match ergonomics diagnostics (rust_2024_incompatible_pat
lint and error))proc_macro
cleanups #147386 (some moreproc_macro
cleanups)LLVMRustAtomicLoad/Store
with LLVM built-in functions #147472 (refactor: replaceLLVMRustAtomicLoad/Store
with LLVM built-in functions)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup